radxa-zero3 maintenance #8794

EvilOlaf · 2025-10-22T04:03:19Z

Description

bump uboot to latest stable
adjust aic8800 extension to build against 6.18

Note: Tried to get rid of vendor uboot altogether but board naming differs, therefore uboot fails to find fdt file.

How Has This Been Tested?

build/boot edge or 3E
test wifi on 3W- nope, no hw

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

coderabbitai · 2025-10-22T04:03:39Z

Walkthrough

The pull request updates Radxa Zero3 board configuration by renaming and rewriting the mainline U-Boot handler function from post_family_config__use_mainline_uboot_except_vendor() to post_family_config__use_mainline_uboot(), inverting its logic to enable mainline U-Boot for all non-vendor branches instead of restricting it to current/edge branches. The BOOTBRANCH default is updated from tag:v2025.10-rc2 to tag:v2025.10. Additionally, the AIC8800 kernel DKMS installation threshold in extensions/radxa-aic8800.sh is raised from kernel 6.18 to 6.19, allowing kernel 6.18.x systems to proceed with DKMS installation instead of skipping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes involve two different files with relatively straightforward logic modifications. While heterogeneous in nature (branch control flow inversion vs. kernel version threshold adjustment), each change is simple and focused without extensive structural reorganization or dense logic patterns.

Possibly related PRs

coolpi-genbook: Add Support for vendor branch #8275: Updates branch-specific post_family_config functions to unified mainline U-Boot handlers and updates BOOTBRANCH/tag values across board config files
Radxa Zero 3: fix bluetooth, for edge & current, switch to u-boot master #8511: Directly modifies radxa-zero3.csc and the post_family_config__use_mainline_uboot_except_vendor function with BOOTBRANCH version changes
extensions: radxa-aic8800: allow 6.17; skip DKMS only on >= 6.18 #8731: Modifies the same radxa-aic8800.sh kernel-version guard threshold in post_install_kernel_debs__install_aic8800_dkms_package

Suggested labels

Needs review, size/medium, Hardware, Patches

Suggested reviewers

igorpecovnik
pyavitz
RadxaYuntian
amazingfate
chainsx

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title Check	❓ Inconclusive	The title "radxa-zero3 maintenance" is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changes. While it correctly identifies the board being updated, it fails to summarize the actual changes, which include bumping U-Boot to the latest stable version and adjusting the aic8800 extension for kernel 6.18. A reader scanning the pull request history would not understand the primary purpose of these changes from the title alone.	Consider revising the title to be more specific and descriptive of the actual changes, such as "radxa-zero3: bump U-Boot to v2025.10 and adjust aic8800 for kernel 6.18" to clearly communicate the main objectives to future reviewers.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The pull request description is directly related to the changeset. It accurately describes the two main changes: bumping U-Boot to the latest stable version (reflected in the BOOTBRANCH update from v2025.10-rc2 to v2025.10) and adjusting the aic8800 extension to build against 6.18 (reflected in the kernel version check modification). The author also provides a note about attempting to remove vendor U-Boot entirely, which aligns with the function renaming and logic changes in the configuration file. The description provides meaningful context about what was changed and includes testing details.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

config/boards/radxa-zero3.csc (1)

59-61: LGTM: Cleaner logic and accurate function naming.

The function rename and logic inversion improve code clarity. The new implementation achieves the same result (enabling mainline U-Boot for current/edge branches while keeping vendor on vendor U-Boot) but with simpler, more maintainable code. The inverted condition [[ "${BRANCH}" == "vendor" ]] is easier to understand than the double-negative pattern it replaces.

The new approach is also more general—any future non-vendor branches will automatically use mainline U-Boot without code changes.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7be3ce0 and d73ac88.

📒 Files selected for processing (2)

config/boards/radxa-zero3.csc (2 hunks)
extensions/radxa-aic8800.sh (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-14T06:32:29.806Z

Learnt from: amazingfate
PR: armbian/build#8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Applied to files:

config/boards/radxa-zero3.csc

🧬 Code graph analysis (2)

extensions/radxa-aic8800.sh (2)

extensions/v4l2loopback-dkms.sh (1)

post_install_kernel_debs__build_v4l2loopback_dkms_kernel_module (15-25)

extensions/bcmdhd.sh (1)

post_install_kernel_debs__install_bcmdhd_dkms_package (11-47)

config/boards/radxa-zero3.csc (1)

config/sources/vendors/mekotronics/mekotronics-rk3588.hooks.sh (2)

post_family_config__meko_use_mainline_uboot (22-42)

post_family_config__vendor_uboot_mekotronics (8-16)

🔇 Additional comments (2)

extensions/radxa-aic8800.sh (1)

13-16: Kernel version threshold adjustment looks correct.

The change from ge 6.18 to ge 6.19 appropriately enables DKMS installation for Linux 6.18 kernels, aligning with the PR objective. The implementation follows the same pattern used in other DKMS extensions.

However, note that Wi-Fi testing on the 3W variant (which uses this AIC8800 extension) was not performed per the PR description. Please verify Wi-Fi functionality on 6.18 kernels when hardware becomes available, or document this limitation if the 3W variant is commonly used.

config/boards/radxa-zero3.csc (1)

66-66: U-Boot version bump to stable is confirmed and ready.

The update from v2025.10-rc2 to v2025.10 is valid—the tag exists in the upstream repository—and the PR reports successful build and boot testing.

igorpecovnik · 2025-10-22T08:27:58Z

https://paste.armbian.com/acidafenox

Connected to XXXXXXXXXXXXX (on wlan0)
	SSID: XXXXXXXXXXXXXXXX
	freq: 5500.0
	RX: 2188 bytes (12 packets)
	TX: 3544 bytes (36 packets)
	signal: -86 dBm
	rx bitrate: 6.0 MBit/s
	tx bitrate: 51.6 MBit/s 40MHz HE-MCS 2 HE-NSS 1 HE-GI 0 HE-DCM 0

github-actions · 2025-10-22T08:29:30Z

✅ This PR has been reviewed and approved — all set for merge!

rpardini · 2025-10-22T16:45:16Z

Note: Tried to get rid of vendor uboot altogether but board naming differs, therefore uboot fails to find fdt file.

@EvilOlaf That could be work-around'ed:

function post_family_config_branch_vendor__zero3_different_dtb_for_vendor() {
	declare -g BOOT_FDT_FILE="rockchip/rk3566-radxa-zero3.dtb"
	display_alert "$BOARD" "Using ${BOOT_FDT_FILE} for ${BRANCH}" "warn"
}

EvilOlaf · 2025-10-22T16:50:36Z

Interesting, I'll try that tomorrow if I find some time.

EvilOlaf added 2 commits October 22, 2025 03:42

get rid of vendor uboot, adjust aic8800

e359f73

mainline uboot doesnt work with vendor kernel

d73ac88

EvilOlaf requested a review from igorpecovnik as a code owner October 22, 2025 04:03

github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Oct 22, 2025

coderabbitai bot requested review from RadxaYuntian, amazingfate, chainsx and pyavitz October 22, 2025 04:04

coderabbitai bot reviewed Oct 22, 2025

View reviewed changes

igorpecovnik approved these changes Oct 22, 2025

View reviewed changes

github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 22, 2025

github-actions bot removed the Needs review Seeking for review label Oct 22, 2025

igorpecovnik merged commit cc671e2 into armbian:main Oct 22, 2025
12 checks passed

EvilOlaf deleted the zero3maint branch October 22, 2025 09:13

coderabbitai bot mentioned this pull request Oct 22, 2025

nanopi-r3s-lts: board config and uboot maintenance #8803

Merged

8 tasks

EvilOlaf mentioned this pull request Oct 23, 2025

radxa-zero3: even more board config maint, abandon vendor uboot #8807

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

radxa-zero3 maintenance #8794

radxa-zero3 maintenance #8794

Uh oh!

EvilOlaf commented Oct 22, 2025 •

edited by igorpecovnik

Loading

Uh oh!

coderabbitai bot commented Oct 22, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

igorpecovnik commented Oct 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

Uh oh!

rpardini commented Oct 22, 2025

Uh oh!

EvilOlaf commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

radxa-zero3 maintenance #8794

radxa-zero3 maintenance #8794

Uh oh!

Conversation

EvilOlaf commented Oct 22, 2025 • edited by igorpecovnik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Uh oh!

coderabbitai bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

igorpecovnik commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

Uh oh!

rpardini commented Oct 22, 2025

Uh oh!

EvilOlaf commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

EvilOlaf commented Oct 22, 2025 •

edited by igorpecovnik

Loading

coderabbitai bot commented Oct 22, 2025 •

edited

Loading

igorpecovnik commented Oct 22, 2025 •

edited

Loading